feat(sum): improve type for list of booleans #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You might want to do a |
aleclarson
reviewed
Jul 29, 2024
src/number/sum.ts
Outdated
Comment on lines
22
to
26
| export function sum<T extends number>(array: readonly T[]): number | ||
| export function sum<T extends object>( | ||
| export function sum<T extends object | boolean>( | ||
| array: readonly T[], | ||
| fn: (item: T) => number, | ||
| ): number |
There was a problem hiding this comment.
The old sum types were bad, so I'd suggest a more ambitious change:
export function sum(array: readonly number[]): number
export function sum<T>(
array: readonly T[],
fn: (item: T) => number,
): numberThere was a problem hiding this comment.
I also prefer your suggestion. It doesn't limit the typing.
There was a problem hiding this comment.
Unfortunately, without removing the any I couldn't get typing to create a valid overload through TypeScript. But I think it improved a bit.
MarlonPassos-git
changed the title
aleclarson
force-pushed
the
feat/sum-improve-bollean-types
branch
from
a75f2e4
to
d9280fa
Compare
aleclarson
added a commit
that referenced
this pull request
Aug 6, 2024
…143) Co-authored-by: Alec Larson <[email protected]>
|
I really appreciate your efforts recently. It'd be great to have you on the core team! Let me know if you'd like an invite. 👍 |
|
@aleclarson Count me in! ✌️ |
|
A new beta version To install: pnpm add [email protected]The 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tip
The owner of this PR can publish a preview release by commenting
/publishin this PR. Afterwards, anyone can try it out by runningpnpm add radashi@pr<PR_NUMBER>.Summary
In a Radash issue, there was a need to handle a list of boolean values. Therefore, I decided to implement a type adjustment to address this case.
Related issue, if any:
sodiray/radash#419
For any code change,
Does this PR introduce a breaking change?
No
Bundle impact