Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(assign): remove inefficiencies in loop #13

Merged
merged 1 commit into from
Jun 24, 2024
Merged

fix(assign): remove inefficiencies in loop #13

merged 1 commit into from
Jun 24, 2024

Conversation

aleclarson
Copy link
Member

Description

Enhanced the assign function for better performance by replacing Object.entries/reduce with a for-in loop.

This has a 2x improvement on ops/s.

JS Benchmark:

Checklist

  • Changes are covered by tests if behavior has been changed or added
  • Tests have 100% coverage
  • If code changes were made, the documentation (in the /docs directory) has been updated

Resolves

Resolves sodiray/radash#395

Thanks to @Kinbaum

@aleclarson aleclarson mentioned this pull request Jun 24, 2024
Closed
@aleclarson aleclarson merged commit 99274cc into main Jun 24, 2024
@aleclarson aleclarson added the upstream fix Fixes a bug that existed in Radash label Jun 28, 2024
@aleclarson aleclarson mentioned this pull request Jun 28, 2024
Open
5 tasks
@aleclarson aleclarson mentioned this pull request Aug 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
upstream fix Fixes a bug that existed in Radash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aleclarson