Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add since tag #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MarlonPassos-git
Copy link

Summary

Add the since tag

image
image
image

and add a title to the byte tag to improve the “hover experience”

image

Related:

radashi-org/radashi#246

How test locally

As the PR for radashi has not yet been approved to run this PR locally, we have to take some steps

  1. after initial setup of the repository, access the radashi folder
  2. run:
    git fetch origin pull/246/head:feature/add-versions
    git checkout feature/add-versions
  3. comment the line number 85 in the file astro.config.ts
    image
  4. run pnpm dev

@aleclarson
Copy link
Member

The version link will be broken for unreleased versions. We have two options here: Add a GitHub action that automatically updates a branch for the next version (e.g. v12.2.0), or link to the main branch instead.

@MarlonPassos-git
Copy link
Author

Thinking about it, I think we could do a validation if the version has already been released. And if it hasn't been released yet, we could show a text like "currently in beta" or something similar.

I think the MD files could continue the way they are, passing the version, but we could do a validation inside the GetStaticPatch function for a prop called isBeta. It would be something like this

image

Initially, I don't think it's necessary to have to use GithubActions

What do you think ?

@aleclarson
Copy link
Member

Sounds like a plan 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants