Bump golang version to 1.10 #463
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HULK PREVIEW |
Allows local builds in golang 1.10 on OS X to work. Done as part of needing a new spin for new OS X version (10.13). This also wraps the version marker in the Travis CI yaml per a known bug (travis-ci/travis-ci#9247) where the version marker was being trapped as 1.1.
filler
force-pushed
the
filler/bump-golang-110
branch
from
956a09e
to
f7d91df
Compare
|
👀 Preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows local builds in golang 1.10 on OS X to work. Done as part of
needing a new spin for new OS X version (10.13).
Also it looks like
goenvwont even have versions <= 1.6 work onHigh Sierra?
Submitting even though I do not think tests ever worked based on
how I read CI.