added error for dimvalues, exported get_scale_defaults (#819 (comment))

NAMESPACE

@@ -123,6 +123,7 @@ S3method(tmapSubsetShp,sf)
 S3method(tmapSubsetShp,sfc)
 S3method(tmapSubsetShp,stars)
 export(get_fact_levels_na)
+export(get_scale_defaults)
 export(make_by_vars)
 export(marker_icon)
 export(opt_tm_bubbles)

R/messages.R

@@ -67,3 +67,7 @@ message_pos_auto = function(type) {
 	NULL	
 }
 
+error_dimvalues = function() {
+	stop("tm_vars(): \"dimvalues\" has been used, but the shape object does not contain any dimensions; please use \"x\" to specify variables", call. = FALSE)
+}
+

R/step1_helper_facets.R

@@ -143,6 +143,9 @@ step1_rearrange_facets = function(tmo, o) {
 						#value = value_orig
 						#names(value) = sapply(value, "[", 1)
 					} else if (inherits(value, "tmapVars")) {
+						if (!is.null(value$dimvalues) && length(smeta$dims) == 0L) {
+							error_dimvalues()
+						}
 						if (!is.na(value$x[1])) {
 							if (is.character(value$x)) {
 								if (!all(value$x %in% shpvars)) stop("not all variables specified in tm_vars are found", call. = FALSE)

R/tmapScale_misc.R

@@ -8,6 +8,18 @@ check_values = function(layer, aes, values) {
 	}
 }
 
+#' Internal tmap function get scale values
+#' 
+#' Internal tmap function get scale values
+#'
+#' @param scale scale
+#' @param o o
+#' @param aes aes
+#' @param layer layer
+#' @param cls cls
+#' @param ct ct
+#' @export
+#' @keywords internal
 get_scale_defaults = function(scale, o, aes, layer, cls, ct = NULL) {
 	within(scale, {
 		values = if (is.na(values[1])) {