Adds link to cli vignette on transition from ui_*() #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces "(LINK TO COME)" text in ui-legacy.R roxygen
jennybc
reviewed
Aug 20, 2024
R/ui-legacy.R
Outdated
| @@ -13,8 +13,7 @@ | |||
| #' | |||
| #' usethis itself now uses cli internally for its UI, but these new functions | |||
| #' are not exported and presumably never will be. There is a developer-focused | |||
| #' article on the process of transitioning usethis's own UI to use cli (LINK | |||
| #' TO COME). | |||
| #' article on the process of transitioning usethis's own UI to use cli [here](https://cli.r-lib.org/articles/usethis-ui.html) | |||
There was a problem hiding this comment.
Actually the intended link is to a usethis article:
https://usethis.r-lib.org/articles/ui-cli-conversion.html
When you update this PR can you also reword the sentence so that instead of having a "here" link, the hyperlink is attached to the article's title (Converting usethis's UI to use cli)? Thanks!
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces "(LINK TO COME)" text in ui-legacy.R roxygen.
No existing issue that I could find.