Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function req_perform_promise (fixes #501) #505

Merged
merged 12 commits into from
Jul 16, 2024

Conversation

gergness
Copy link
Contributor

An implementation of req_perform_promise() - #501

It has worked pretty well in my initial testing, though the way I'm tracking which pools already have a later task polling them does feel a little fragile.

Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple of small comments but I'll try and find someone who knows more about promises than me to take a deeper look.

R/req-promise.R Outdated Show resolved Hide resolved
R/req-promise.R Outdated Show resolved Hide resolved
R/req-promise.R Outdated Show resolved Hide resolved
R/req-promise.R Outdated Show resolved Hide resolved
Copy link
Member

@jcheng5 jcheng5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work, thank you!

@hadley hadley merged commit 18b1a49 into r-lib:main Jul 16, 2024
13 checks passed
@hadley
Copy link
Member

hadley commented Jul 16, 2024

Thanks @gergness!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants