-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function req_perform_promise (fixes #501) #505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a couple of small comments but I'll try and find someone who knows more about promises than me to take a deeper look.
Co-authored-by: Hadley Wickham <[email protected]>
Co-authored-by: Joe Cheng <[email protected]>
Co-authored-by: Hadley Wickham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive work, thank you!
Thanks @gergness! |
An implementation of
req_perform_promise()
- #501It has worked pretty well in my initial testing, though the way I'm tracking which pools already have a later task polling them does feel a little fragile.