Skip to content

Commit

Permalink
Merge commit '953ae4ec8e7fb3934f02acafd64275a0458cab43'
Browse files Browse the repository at this point in the history
  • Loading branch information
hadley committed Jul 16, 2024
2 parents 31f2ce9 + 953ae4e commit 8edb90f
Show file tree
Hide file tree
Showing 10 changed files with 21 additions and 82 deletions.
6 changes: 3 additions & 3 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
Package: httr2
Title: Perform HTTP Requests and Process the Responses
Version: 1.0.1.9000
Version: 1.0.2.9000
Authors@R: c(
person("Hadley", "Wickham", , "hadley@rstudio.com", role = c("aut", "cre")),
person("RStudio", role = c("cph", "fnd")),
person("Hadley", "Wickham", , "hadley@posit.co", role = c("aut", "cre")),
person("Posit Software, PBC", role = c("cph", "fnd")),
person("Maximilian", "Girlich", role = "ctb")
)
Description: Tools for creating and modifying HTTP requests, then
Expand Down
13 changes: 7 additions & 6 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
# httr2 (development version)

* `req_perform_parallel()` now respects error handling in `req_error()`

# httr2 1.0.2

* `req_body_file()` now only opens a connection when the request actually needs data. In particular, this makes it work better with `req_perform_parallel()` (#487).
* `req_cache()` no longer fails if the `rds` files are somehow corrupted and now defaults the `debug` argument to the `httr2_cache_debug` option to make it easier to debug caching buried in other people's code (#486).
* `req_oauth_password()` now only asks for your password once (#498).
* `req_perform_parallel()` now works correctly with `req_cache()` (#447) and now works when downloading 0 byte files (#478)
* `req_perform_stream()` no longer applies the `callback` to unsuccessful
responses, instead creating a regular response. It also now sets `last_request()` and `last_response()` (#479).
* `req_cache()` now defaults the `debug` argument to the `httr2_cache_debug` option to make it easier to debug caching buried in other people's code (#486).
* `req_oauth_password()` now only asks for your password once (#498).
* `req_url_query()` now allows you to opt out of escaping for multi-value parameters (#404).
* `req_perform_parallel()` now works correctly with `req_cache()` (#447).
* `req_body_file()` now only opens a connection when the request actually needs data. In particular, this makes it work better with `req_perform_parallel()` (#487).
* `req_perform_parallel()` now works when downloading 0 byte files (#478)
* `req_cache()` no longer fails if the `rds` files are somehow corrupted

# httr2 1.0.1

Expand Down
2 changes: 1 addition & 1 deletion R/progress-bars.R
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#' the progress bar type. It must be given for the `custom` type.
#' Format strings may contain R expressions to evaluate in braces.
#' They support cli [pluralization][cli::pluralization], and
#' [styling][inline-markup] and they can contain special
#' [styling][cli::inline-markup] and they can contain special
#' [progress variables][cli::progress-variables].
#' * `format_done`: format string for successful termination. By default
#' the same as `format`.
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ And see exactly what httr2 will send to the server with `req_dry_run()`:
req |> req_dry_run()
#> GET / HTTP/1.1
#> Host: r-project.org
#> User-Agent: httr2/1.0.1.9000 r-curl/5.2.1 libcurl/8.4.0
#> User-Agent: httr2/1.0.1.9000 r-curl/5.2.1 libcurl/8.6.0
#> Accept: */*
#> Accept-Encoding: deflate, gzip
```
Expand All @@ -90,7 +90,7 @@ resp
#> GET https://www.r-project.org/
#> Status: 200 OK
#> Content-Type: text/html
#> Body: In memory (7040 bytes)
#> Body: In memory (6951 bytes)
```

The `resp_` functions help you extract various useful components of the
Expand Down
5 changes: 2 additions & 3 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@

## revdepcheck results

We checked 57 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
We checked 110 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

* We saw 1 new problems with happign: this looks like user error,
but I've supplied a patch at https://github.com/paul-carteron/happign/pull/22.
* We saw 0 new problems
* We failed to check 0 packages
4 changes: 2 additions & 2 deletions man/httr2-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/progress_bars.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 0 additions & 6 deletions revdep/README.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,2 @@
# Revdeps

## New problems (1)

|package |version |error |warning |note |
|:-------|:-------|:------|:-------|:----|
|[happign](problems.md#happign)|0.2.0 |__+1__ | |1 |

12 changes: 2 additions & 10 deletions revdep/cran.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,7 @@
## revdepcheck results

We checked 57 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
We checked 110 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

* We saw 1 new problems
* We saw 0 new problems
* We failed to check 0 packages

Issues with CRAN packages are summarised below.

### New problems
(This reports the first line of each new failure)

* happign
checking tests ... ERROR

49 changes: 1 addition & 48 deletions revdep/problems.md
Original file line number Diff line number Diff line change
@@ -1,48 +1 @@
# happign

<details>

* Version: 0.2.0
* GitHub: https://github.com/paul-carteron/happign
* Source code: https://github.com/cran/happign
* Date/Publication: 2023-08-07 19:10:02 UTC
* Number of recursive dependencies: 120

Run `revdepcheck::cloud_details(, "happign")` for more info

</details>

## Newly broken

* checking tests ... ERROR
```
Running ‘testthat.R’
Running the tests in ‘tests/testthat.R’ failed.
Complete output:
> library(testthat)
> library(happign)
Please make sure you have an internet connection.
Use happign::get_last_news() to display latest geoservice news.
>
> test_check("happign")
Linking to GEOS 3.8.0, GDAL 3.0.4, PROJ 6.3.1; sf_use_s2() is TRUE
...
6. │ └─rlang::eval_bare(quo_get_expr(.quo), quo_get_env(.quo))
7. └─happign:::build_req(path, "test")
8. └─httr2::req_url_query(...)
9. └─httr2:::query_build(dots)
10. └─cli::cli_abort("Query must be a named list.", call = error_call)
11. └─rlang::abort(...)
[ FAIL 1 | WARN 21 | SKIP 24 | PASS 64 ]
Error: Test failures
Execution halted
```

## In both

* checking data for non-ASCII characters ... NOTE
```
Note: found 7592 marked UTF-8 strings
```

*Wow, no problems at all. :)*

0 comments on commit 8edb90f

Please sign in to comment.