Add feature to adjust fade duration (with Elektra) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markus2330
suggested changes
Sep 20, 2021
src/elektra/redshift.ni
Outdated
| @@ -94,6 +94,14 @@ opt = f | |||
| opt/long = fade-fast | |||
| opt/arg = none | |||
|
|
|||
| [fade/duration] | |||
| type = unsigned_long | |||
| description = Set fade duration (for fading between color temperatures) in full seconds. | |||
There was a problem hiding this comment.
Suggested change
| description = Set fade duration (for fading between color temperatures) in full seconds. | |
| description = Set length of the fade duration in full seconds for fading between color temperatures. |
There was a problem hiding this comment.
Yes, this is easier to understand, thank you!
| @@ -398,6 +400,7 @@ options_init(options_t *options) | |||
| options->provider = NULL; | |||
|
|
|||
| options->use_fade = -1; | |||
| options->fade_duration = -1; | |||
There was a problem hiding this comment.
Thanks, fixed. I also adjusted CLion IDE to better detect existing indents in files.
src/options.h
Outdated
| @@ -34,6 +34,8 @@ typedef struct { | |||
| int temp_set; | |||
| /* Whether to fade between large skips in color temperature. */ | |||
| int use_fade; | |||
| /* The length of the fade duration in seconds */ | |||
There was a problem hiding this comment.
This should probably link to the spec "fade/duration" and not repeat the description?
There was a problem hiding this comment.
Yes, thanks for the hint!
added 4 commits
September 21, 2021 10:35
# Conflicts: # src/options.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@markus2330: This PR implements a new configuration value "fade duration" in redshift with Elektra.
It will be used to compare the implementation of new configuration values without vs. with Elektra.