Validate qml in Python #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alidate-qml-in-py
KitsuneRal
reviewed
Aug 21, 2021
| def __init__(self, *args, **kwargs) -> None: | ||
| super().__init__(*args, **kwargs) | ||
|
|
||
| QtQml.qmlRegisterUncreatableType(Quotient.EventStatus, 'Quotient', 1, 0, 'EventStatus', 'EventStatus is not a creatable type') |
There was a problem hiding this comment.
I suppose this doesn't work now that EventStatus is a namespace (since yesterday in master - sorry for taking time to resolve this)?
| # Resource object code (Python 3) | ||
| # Created by: object code | ||
| # Created by: The Resource Compiler for Qt version 6.1.1 | ||
| # WARNING! All changes made in this file will be lost! |
There was a problem hiding this comment.
Should this file be under version control or does the build system recreate it every time the bindings are generated?
There was a problem hiding this comment.
As we decide. Actually, it's not generated in build system, but it's easy to do so. Should I? It's autogenerated python wrapper for resources, so it makes sense, yes.
There was a problem hiding this comment.
As discussed, let's make generation of this file a part of the build sequence; but please double-check with PySide people what they think about it.
…alidate-qml-in-py
…has not meta data and cannot be registered as qml type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24