chore: align go version with docs #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1417 +/- ##
==========================================
- Coverage 55.36% 55.32% -0.04%
==========================================
Files 282 282
Lines 17861 17861
==========================================
- Hits 9888 9881 -7
- Misses 6934 6939 +5
- Partials 1039 1041 +2 ☔ View full report in Codecov by Sentry. |
RTann
previously approved these changes
Sep 19, 2024
crozzy
force-pushed
the
downgrade-go-version
branch
from
ee70b68
to
8ac2b06
Compare
|
Also removing |
hdonnay
approved these changes
Sep 19, 2024
hdonnay
requested changes
Sep 19, 2024
Updating to go1.22.7 which is/was the latest patch is not in-line with our own documentation https://github.com/crozzy/claircore/blob/main/docs/contributor/go_version.md. Signed-off-by: crozzy <[email protected]>
crozzy
force-pushed
the
downgrade-go-version
branch
from
8ac2b06
to
66c3c9b
Compare
RTann
approved these changes
Sep 19, 2024
hdonnay
approved these changes
Sep 20, 2024
|
/fast-forward |
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to go1.22.7 which is/was the latest patch is not in-line with our own documentation https://github.com/crozzy/claircore/blob/main/docs/contributor/go_version.md.