chore: seperate line output when a release is missing changelog #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was annoying as PRs that needed changelog entries were being displayed without line breaks so it was difficult to parse. Signed-off-by: crozzy <[email protected]>
|
@hdonnay I suspect you might have some better bash jiu jitsu |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1302 +/- ##
==========================================
+ Coverage 55.77% 55.78% +0.01%
==========================================
Files 265 265
Lines 16557 16557
==========================================
+ Hits 9235 9237 +2
+ Misses 6362 6361 -1
+ Partials 960 959 -1 ☔ View full report in Codecov by Sentry. |
hdonnay
reviewed
Apr 2, 2024
| @@ -20,7 +20,7 @@ done | |||
| shift $((OPTIND - 1)) | |||
| VERSION="${1:?need a version argument}" | |||
| VERSION="v${VERSION#v}" | |||
|
|
|||
| IFS= | |||
There was a problem hiding this comment.
I'd suggest something like:
gh search prs --state closed --merged --label=needs-changelog --json=title,url | jq -r '.[] | (.url | @text) + " - " + (.title | @text)' > /tmp/prs
if [ -s /tmp/prs ]; then
echo "There are still PRs that need changelog entries"
cat /tmp/prs
exit 1
fi
|
Want me to push this over the finish line? |
Sure, sorry only just seen this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was annoying as PRs that needed changelog entries were being displayed without line breaks so it was difficult to parse.