Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libindex: add some guess at layer preallocation sizing #1202

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hdonnay
Copy link
Member

@hdonnay hdonnay commented Jan 10, 2024

This is an idea I had that I threw together.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 56.45%. Comparing base (417c2b0) to head (134bdde).
Report is 4 commits behind head on main.

❗ Current head 134bdde differs from pull request most recent head 5670344. Consider uploading reports for the commit 5670344 to get more accurate results

Files Patch % Lines
libindex/fetcher.go 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1202      +/-   ##
==========================================
+ Coverage   55.33%   56.45%   +1.11%     
==========================================
  Files         265      233      -32     
  Lines       16574    15370    -1204     
==========================================
- Hits         9172     8677     -495     
+ Misses       6451     5807     -644     
+ Partials      951      886      -65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hdonnay
Copy link
Member Author

hdonnay commented Mar 25, 2024

This uses the mean, but probably shouldn't. Something like a running median would be better, but would require an indexed skip list implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant