Use user's selected language for next code cell
#540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
force-pushed
the
feature/use-known-language
branch
from
4733d6d
to
1a92927
Compare
jjallaire
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #425
With this PR, we more aggressively use the "remembered"
language. We now just straight up insert thatlanguagein the code cell rather than just putting it 1st in the order of potential languages to use. This allows us to put the user's cursor directly into the code cell when they hit the keyboard shortcut.Note this does not apply to Visual Editor, which I guess uses a very different path.
Screen.Recording.2024-09-13.at.4.54.46.PM.mov
The downside of this approach is that it isn't easily possible to get the list of potential languages to pop back up if you need to switch languages. They are basically hard coded in this one code path that now corresponds to "we don't know what language you want, so please pick one".
There do seem to be some completions that pop up inside the
{}(see the video), so in a separate PR maybe we can hook into that completion engine to get the list of language names to pop back up?