Strip leading slash from logical names #172
Conversation
|
I notice that document also says that we should percent encode non-ASCII. In order to properly do that, I'd have to confirm which encoding the |
|
Ah, digging went quickly. It seems this I'm now trying to find the exact definition of percent encoding in this context, but my internet has decided that 3kb/s is as fast as things are going today :( |
|
@luke-clifton I'd skip percent-encoding at least until we find it used for Excel files, mentioning that in a comment would be enough |
|
Closes #171 |
src/Codec/Xlsx/Parser.hs
Outdated
| -- According to part 2, section 7.3.4 of ECMA-376, when mapping logical item | ||
| -- names to ZIP item names we need to remove the leading slash. | ||
| -- | ||
| -- <http://www.ecma-international.org/publications/standards/Ecma-376.htm> |
There was a problem hiding this comment.
This link looks to be outdated - it returns 404 for me.
The new Url appears to be https://ecma-international.org/publications-and-standards/standards/ecma-376/
There was a problem hiding this comment.
Updated, sorry.
There was a problem hiding this comment.
np, I guess I should also update the link in cabal
According to part 2, section 7.3.4 of ECMA-376, when mapping logical item names to ZIP item names we need to remove the leading slash. <http://www.ecma-international.org/publications/standards/Ecma-376.htm>
luke-clifton
force-pushed
the
logicaltozipname
branch
from
086ad0e
to
d0c2864
Compare
|
I think this is ready. |
|
Great, thanks @luke-clifton ! |
|
It took me a while but 1.1.2 is on Hackage |
According to part 2, section 7.3.4 of ECMA-376, when mapping logical item names to ZIP item names we need to remove the leading slash.
http://www.ecma-international.org/publications/standards/Ecma-376.htm