Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLF4J-447: Move org.slf4j.NDC from slf4j-ext to slf4j-api #260

Open
wants to merge 1 commit into
base: 1.7-maintenance
Choose a base branch
from

Conversation

candrews
Copy link

@candrews candrews commented May 6, 2021

sfl4j-api owns the org.slf4j package (automatic Java module);
slf4j-ext must not have any classes in the org.slf4j package.

Note that the NDCTest stays in slf4j-ext.
The test cannot be moved to slf4j-api because slf4j-api includes
a stub StaticMDCBinder instead of a real one resulting the test
failing.

https://jira.qos.ch/browse/SLF4J-447

I think it would be really nice to get this change into a 1.7.x release.

sfl4j-api owns the org.slf4j package (automatic Java module);
slf4j-ext must not have any classes in the org.slf4j package.

Note that the NDCTest stays in slf4j-ext.
The test cannot be moved to slf4j-api because slf4j-api includes
a stub StaticMDCBinder instead of a real one resulting the test
failing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant