Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add qt6 apt package suggestion #7

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Jun 7, 2024

No description provided.

@Chocobo1 Chocobo1 merged commit 0406c78 into qbittorrent:master Jun 10, 2024
1 check passed
@Chocobo1
Copy link
Member

@trim21
Thank you!

@trim21 trim21 deleted the patch-1 branch June 10, 2024 19:15
@Piccirello
Copy link
Member

It's worth noting that even on Ubuntu 24.04, the qt6 packages are too old to be used. Ubuntu supplies qt 6.4.2 while qBittorrent requires 6.5.0. I wish qBittorrent's version requirements would take into account Ubuntu's available packages.

@trim21
Copy link
Contributor Author

trim21 commented Jun 11, 2024

It's worth noting that even on Ubuntu 24.04, the qt6 packages are too old to be used. Ubuntu supplies qt 6.4.2 while qBittorrent requires 6.5.0. I wish qBittorrent's version requirements would take into account Ubuntu's available packages.

It means qbittorent didn't check qt version it's using?

I tried qb master branch with these package in ubuntu and compile passed.

@Piccirello
Copy link
Member

I'd have to try tonight/tomorrow to confirm but I would expect it to fail on the master branch.

https://github.com/qbittorrent/qBittorrent/blob/dd34c85884c77e3d4d6fc7223decdf47789affb6/CMakeLists.txt#L11

@trim21
Copy link
Contributor Author

trim21 commented Jun 11, 2024

interesting, looks like I didnt actually use master branch, because it can't compile it anymore in ci.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants