-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the ability to create torrents with a piece size of 256MiB #21295
base: master
Are you sure you want to change the base?
Conversation
Please add description of "why" is it done. |
Done. |
What needs to be done really IMO is for libtorrent 1.2.x to reject those torrents from actually being loaded. |
What will happen to the torrents already added? And like I said, 2.0 also has an issue (at least with creating torrents, but I think with rehash too) with the 512MB and 1GB piece size. Maybe for 2.0 this has already been fixed, I don't know. |
Can this be merged and added to the backport to 5.0? |
Creation of torrents >256MiB in qBittorrent (LT20) was blocked/limited intentionally. #21011 & other tickets showed that even if we reduced the ability in qBittorrent to create torrents with a piece size of 256MiB, there are programs/options to force creation of such large piece size.
Plan should be:
|
Wouldn't it be better to just temporarily limit torrent creation to 256MiB torrents in 2.0 until lt 1.2 is fixed? |
|
In any case, users are already using torrents with a 256MiB piece size for lt1.2 and won't be happy with that.
But these restrictive measures still won't fix the issue for lt1.2... |
As I said, it can be used as a temporary solution for 5.0, which won't break anything for sure. Anyway, I don't have the skills to make something bigger. |
Disabling will reduce the number of users experiencing this issue.