Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The GetCellRichText function support to return inline rich text #1724

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

parkoo
Copy link
Contributor

@parkoo parkoo commented Nov 20, 2023

PR Details

The GetCellRichText function support to return inline rich text

Description

The GetCellRichText function support to return inline rich text

Related Issue

N/A

Motivation and Context

The GetCellRichText function returns error strconv.Atoi: parsing "": invalid syntax in some cases

How Has This Been Tested

Existing unit tests and new test cases passed

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6220a79) 99.04% compared to head (f00b642) 99.04%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1724   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files          32       32           
  Lines       28400    28410   +10     
=======================================
+ Hits        28130    28140   +10     
  Misses        179      179           
  Partials       91       91           
Flag Coverage Δ
unittests 99.04% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@xuri xuri merged commit 55e4d4b into qax-os:master Nov 20, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants