-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support update drawing objects on inserting/deleting columns/rows #1127
Conversation
Now my skills are weak to implement needed functions and fix decode with tags |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #1127 +/- ##
=======================================
Coverage 99.03% 99.03%
=======================================
Files 32 32
Lines 28015 28100 +85
=======================================
+ Hits 27745 27830 +85
Misses 179 179
Partials 91 91
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your contribution. I have made some changes based on your branch. This feature will be released in the next version.
PR Details
Add an adjusting of drawing coordinates
Description
Added functions to get drawing data and adjust all it's anchors' coordinates
Now it's can't decode xml-files because of structs' fields tags
Not implemented functions to update anchor's innerXML data with changes and to make correct document with current anchor's innerXML data
Related Issue
issue
Motivation and Context
In my work project We need add and delete cols and rows, and document content should move adaptively
How Has This Been Tested
It should be tested with adding picture in sheet and then add few rows before picture target cell
Types of changes
Checklist