Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support update drawing objects on inserting/deleting columns/rows #1127

Merged
merged 6 commits into from
Nov 6, 2023

Conversation

kjushka
Copy link
Contributor

@kjushka kjushka commented Jan 20, 2022

PR Details

Add an adjusting of drawing coordinates

Description

Added functions to get drawing data and adjust all it's anchors' coordinates
Now it's can't decode xml-files because of structs' fields tags
Not implemented functions to update anchor's innerXML data with changes and to make correct document with current anchor's innerXML data

Related Issue

issue

Motivation and Context

In my work project We need add and delete cols and rows, and document content should move adaptively

How Has This Been Tested

It should be tested with adding picture in sheet and then add few rows before picture target cell

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [x ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kjushka
Copy link
Contributor Author

kjushka commented Jan 20, 2022

Now my skills are weak to implement needed functions and fix decode with tags
Its my work, and i believe that it will help you

@kjushka kjushka marked this pull request as ready for review January 27, 2022 12:26
@xuri xuri added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 28, 2022
@xuri xuri marked this pull request as draft July 10, 2023 07:02
@xuri xuri changed the title DRAFT: add adjust function for drawings Support update drawing objects on inserting/deleting columns/rows Nov 4, 2023
@xuri xuri marked this pull request as ready for review November 4, 2023 16:15
@xuri xuri added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2023

Codecov Report

Merging #1127 (f2b4528) into master (f753e56) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master    #1127   +/-   ##
=======================================
  Coverage   99.03%   99.03%           
=======================================
  Files          32       32           
  Lines       28015    28100   +85     
=======================================
+ Hits        27745    27830   +85     
  Misses        179      179           
  Partials       91       91           
Flag Coverage Δ
unittests 99.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
adjust.go 99.52% <100.00%> (+0.09%) ⬆️
picture.go 100.00% <100.00%> (ø)

Copy link
Member

@xuri xuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution. I have made some changes based on your branch. This feature will be released in the next version.

@xuri xuri merged commit fe639fa into qax-os:master Nov 6, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants