Remove redundant len check in GroupSheets and UngroupSheets (#1685

)
qax-os · Oct 12, 2023 · f752f2d · f752f2d
1 parent d9a0da7
commit f752f2d
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/sheet.go b/sheet.go
@@ -1739,11 +1739,8 @@ func (f *File) GroupSheets(sheets []string) error {
 	}
 	for _, ws := range wss {
 		sheetViews := ws.SheetViews.SheetView
-		if len(sheetViews) > 0 {
-			for idx := range sheetViews {
-				ws.SheetViews.SheetView[idx].TabSelected = true
-			}
-			continue
+		for idx := range sheetViews {
+			ws.SheetViews.SheetView[idx].TabSelected = true
 		}
 	}
 	return nil
@@ -1758,10 +1755,8 @@ func (f *File) UngroupSheets() error {
 		}
 		ws, _ := f.workSheetReader(sheet)
 		sheetViews := ws.SheetViews.SheetView
-		if len(sheetViews) > 0 {
-			for idx := range sheetViews {
-				ws.SheetViews.SheetView[idx].TabSelected = false
-			}
+		for idx := range sheetViews {
+			ws.SheetViews.SheetView[idx].TabSelected = false
 		}
 	}
 	return nil