Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax space group requirement when creating phase from CIF #522

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Relax space group requirement when creating phase from CIF #522

merged 4 commits into from
Sep 20, 2024
+456 −429

Commits on Sep 19, 2024

  1. Relax space_group check in Phase.from_cif(), improve type hinting 

    Signed-off-by: Håkon Wiik Ånes <[email protected]>
    @hakonanes
    hakonanes committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    d186467 View commit details
    Browse the repository at this point in the history

  2. Restructure PhaseList and Phase test files to ease running separately 

    Signed-off-by: Håkon Wiik Ånes <[email protected]>
    @hakonanes
    hakonanes committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    05c09b7 View commit details
    Browse the repository at this point in the history

  3. List fix to Phase.from_cif() in changelog 

    Signed-off-by: Håkon Wiik Ånes <[email protected]>
    @hakonanes
    hakonanes committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    58b4a68 View commit details
    Browse the repository at this point in the history

  4. Don't cover except-clause in Phase.from_cif() 

    Signed-off-by: Håkon Wiik Ånes <[email protected]>
    @hakonanes
    hakonanes committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6df980e View commit details
    Browse the repository at this point in the history