Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build and publish aarch64 wheels #100

Closed
wants to merge 1 commit into from
Closed

Build and publish aarch64 wheels #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/build-and-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,13 @@ jobs:
with:
ref: ${{ github.event.inputs.branch }}
submodules: true

- name: Set up QEMU
if: runner.os == 'Linux'
uses: docker/setup-qemu-action@v3
with:
platforms: all

- name: Install Python
uses: actions/setup-python@v5
with:
Expand All @@ -37,10 +44,16 @@ jobs:
env:
CIBW_SKIP: "cp36-*" # skip 3.6
CIBW_ARCHS_MACOS: "x86_64 universal2 arm64"
CIBW_ARCHS_LINUX: "auto aarch64"
- uses: actions/upload-artifact@v4
with:
name: python-package-distributions-macos
path: ./wheelhouse/*.whl
- uses: actions/upload-artifact@v4
with:
name: python-package-distributions-linux
path: ./wheelhouse/*.whl
Comment on lines 50 to +55
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this could be simplified to:

Suggested change
name: python-package-distributions-macos
path: ./wheelhouse/*.whl
- uses: actions/upload-artifact@v4
with:
name: python-package-distributions-linux
path: ./wheelhouse/*.whl
name: python-package-distributions-wheels
path: ./wheelhouse/*.whl

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that will work too. Actually I did it differently when testing it in my repo: vermut@1598f50

also note setuptools addition - I had issue with that in on the runs: https://github.com/vermut/marisa-trie/actions/runs/8961082399/job/24608308956

This comment was marked as outdated.

Sign in to view

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your version is way better, could you apply it here too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, and you already fixed the setuptools issue. Let's also fix it in that PR :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just create a PR from my master. Squash the WIP commits when merging.



source-distribution:
name: Build source distribution
Expand Down
Loading