Persistent version of Flash Attention #2407
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
manman-ren
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
manman-ren
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
plotfi
reviewed
Aug 2, 2024
|
|
||
| @triton.autotune(list(filter(keep, configs)), key=["N_CTX"]) | ||
| @triton.jit | ||
| def _attn_fwd_persistent_tma(Q, Out, desc_q, desc_k, desc_v, sm_scale, M, desc_o, # |
There was a problem hiding this comment.
Is this a copy of _attn_fwd_persistent but with TMA changes?
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
manman-ren
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
manman-ren
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two more variants: triton_tutorial_flash_v2_persistent and triton_tutorial_flash_v2_persistent_tma
The variants handle non-causal only. For causal, it has 2 invocations to attn_fwd_inner, which means we will have an outerloop and 2 inner loops
for ... # persistent loop
for ...
for ...
It is not clear how to flatten it into a 1D loop.