Image -> Arrow support #8330
Open
Image -> Arrow support #8330
+583
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed format, only for 4 channel images
* structs can't be encoded this way, they need to have one child array per struct member. * i.e. struct of arrays, rather than an array of structs.
wiredfool
force-pushed
the
arrow
branch
2 times, most recently
from
5ac1164
to
b5a261e
Compare
for more information, see https://pre-commit.ci
Open
radarhere
reviewed
Aug 26, 2024
|
|
||
| def __arrow_c_array__( | ||
| self, requested_schema: object | None = None | ||
| ) -> Tuple[object, object]: |
There was a problem hiding this comment.
Suggested change
| ) -> Tuple[object, object]: | |
| ) -> tuple[object, object]: |
There was a problem hiding this comment.
It's directly from here: https://arrow.apache.org/docs/format/CDataInterface/PyCapsuleInterface.html#protocol-typehints
There was a problem hiding this comment.
pyarrow still supports Python 3.8 - https://pypi.org/project/pyarrow/
Since we don't, it can be updated - https://peps.python.org/pep-0585/#implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial implementation of #8329.
This is for discussion -- there are a number of issues.
Changes proposed in this pull request:
__arrow_c_array__and__arrow_c_schema__support for reading Pillow images in Arrow capable libraries.Issues: