Remove ResourceWarnings from tests #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The open().read() calls were causing ResourceWarnings because the file was never explicitly closed, and are now replaced with a context managed open() call. In the case of the popens the reading from the stdout member had the same issue, so I'm replacing the stdout.read() + wait() with communicate() (which internally exhausts stdout and waits) + returncode. All in all, this takes the warning count when running all tests from 45 down to 11, all of which are PytestUnraisableExceptionWarnings. Signed-off-by: Rodrigo Tobar <[email protected]>
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The open().read() calls were causing ResourceWarnings because the file was never explicitly closed, and are now replaced with a context managed open() call. In the case of the popens the reading from the stdout member had the same issue, so I'm replacing the stdout.read() + wait() with communicate() (which internally exhausts stdout and waits) + returncode.
All in all, this takes the warning count when running all tests from 45 down to 11, all of which are PytestUnraisableExceptionWarnings.