Chore: Simplify results table hooks #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeyondEvil
force-pushed
the
beyondevil/data-to-json
branch
5 times, most recently
from
555d19b
to
09798e1
Compare
BeyondEvil
force-pushed
the
beyondevil/data-to-json
branch
from
09798e1
to
9712fdf
Compare
BeyondEvil
force-pushed
the
beyondevil/data-to-json
branch
from
9712fdf
to
8c49379
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically removes the overly complex solution to modify the result table (header and row hooks), and restores it to more resemble the legacy way.
The user is free to edit freely, but also responsible to make sure that whatever they do - renders properly in the report.
Please review this @drRedflint even if it has been merged, thank you!