Add --force-reinstall to pip args when --force was passed
#933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
approved these changes
Jul 3, 2023
potiuk
added a commit
to potiuk/pipx
that referenced
this pull request
Dec 2, 2023
The 1.3.0 version of `pipx` (with pypa#933) introduced a but where the `--force-reinstall` flag caused failure when also the `--editable` flag was used - because it was adding the `--force-reinstall` flag after `--editable` one (and `--editable` flag expects url/path to the Python package to install to follow it. The change fixes it by adding the `--force-reinstall` flag at the beginning rather than at the end of arguments to avoid this kind of problem also in case other flags might have similar problem. Fixes: pypa#1122
1 task
potiuk
added a commit
to potiuk/pipx
that referenced
this pull request
Dec 2, 2023
The 1.3.0 version of `pipx` (with pypa#933) introduced a but where the `--force-reinstall` flag caused failure when also the `--editable` flag was used - because it was adding the `--force-reinstall` flag after `--editable` one (and `--editable` flag expects url/path to the Python package to install to follow it. The change fixes it by adding the `--force-reinstall` flag at the beginning rather than at the end of arguments to avoid this kind of problem also in case other flags might have similar problem. Fixes: pypa#1122
potiuk
added a commit
to potiuk/pipx
that referenced
this pull request
Dec 2, 2023
The 1.3.0 version of `pipx` (with pypa#933) introduced a but where the `--force-reinstall` flag caused failure when also the `--editable` flag was used - because it was adding the `--force-reinstall` flag after `--editable` one (and `--editable` flag expects url/path to the Python package to install to follow it. The change fixes it by adding the `--force-reinstall` flag at the beginning rather than at the end of arguments to avoid this kind of problem also in case other flags might have similar problem. Fixes: pypa#1122
potiuk
added a commit
to potiuk/pipx
that referenced
this pull request
Dec 2, 2023
The 1.3.0 version of `pipx` (with pypa#933) introduced a but where the `--force-reinstall` flag caused failure when also the `--editable` flag was used - because it was adding the `--force-reinstall` flag after `--editable` one (and `--editable` flag expects url/path to the Python package to install to follow it. The change fixes it by adding the `--force-reinstall` flag at the beginning rather than at the end of arguments to avoid this kind of problem also in case other flags might have similar problem. Fixes: pypa#1122
gaborbernat
pushed a commit
that referenced
this pull request
Dec 2, 2023
* Fix combining of `--editable` and `--force` flag The 1.3.0 version of `pipx` (with #933) introduced a but where the `--force-reinstall` flag caused failure when also the `--editable` flag was used - because it was adding the `--force-reinstall` flag after `--editable` one (and `--editable` flag expects url/path to the Python package to install to follow it. The change fixes it by adding the `--force-reinstall` flag at the beginning rather than at the end of arguments to avoid this kind of problem also in case other flags might have similar problem. Fixes: #1122 * fixup! Fix combining of `--editable` and `--force` flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/changelog.mdSummary of changes
Closes #582, #902, #929
Test plan
Tested by running