Manually parse URL without depending on packaging #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New packaging removed URL validation, so we implement our own. To accomodate the new packaging validation (or lack thereof), the valid URL rule is relaxed a bit; unknown schemes are now allowed (and will error later when we try to fetch them).
dukecat0
approved these changes
Oct 2, 2023
|
I’ll merge this into main so this can be more easily tested (with Homebrew for example), but anyone with this issue is very welcomed to test code in main and give feedback please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1070.
New packaging removed URL validation, so we implement our own. To accomodate the new packaging validation (or lack thereof), the valid URL rule is relaxed a bit; unknown schemes are now allowed (and will error later when we try to fetch them).
I didn’t add an entry to the change log since this shouldn’t affect the functionality. If anything does change, it should be considered a bug.