fix(install): set v1.8.0 as upper-bound on userpath #1034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess we don't need this anymore since userpath v1.9.1 has been released. |
|
Or add a |
This fixes the functional regression introduced by userpath v1.9.0. For details see issue pypa#1025. Signed-off-by: Simon A. F. Lund <[email protected]>
|
I have bumped the version number, yet still keeping an upper-bound. |
|
I don’t think it is a good idea to add an upper bound. If the regression reasoning is followed, we should add upper bounds to all dependencies. |
Yes. From my perspective then adding upper bounds on all dependencies is preferable to arbitrary functional regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the functional regression introduced by userpath v1.9.0. For details see issue #1025.