-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep old reference to fix PEP 621 build #1434
Conversation
@hugovk looks like maybe an empty line is needed? |
No, they can be next to each other, see for example https://github.com/python/devguide/blob/main/documentation/start-documenting.rst?plain=1 The other warnings were also introduced by the re-org in #1396 plus another PR landing at the same time, see #1396 (comment). Edit: And will be fixed by #1433. |
I'm not against preserving labels when doing reorganizations. I want to point out, though, that if we want to treat our Intersphinx "interface" as public API, we also need to avoid removing any rst files, using orphan pages instead, since they can also be referenced with |
We've fixed this for the PEPs by updating the reference: However, we're still running into build failures when updating PRs created more than a week ago, for example:
We can fix them by updating them from Thank you! |
Thanks @hugovk. |
The removal of the
.. _declaring-project-metadata:
reference in #1396 has broken the PEPs build because PEP 621 used to link here via Intersphinx:https://github.com/python/peps/actions/runs/7092751804/job/19304712978
https://github.com/python/peps/blob/ff0702ebfce6e5196a0969e609d2a45e5bd41843/peps/pep-0621.rst?plain=1#L23
I think retaining the old reference should fix it.
Instead/also, we could update PEP 621 to point to the new reference. I don't really mind, but there could be other sites also linking via intersphinx so perhaps this is the more general fix.
📚 Documentation preview 📚: https://python-packaging-user-guide--1434.org.readthedocs.build/en/1434/