Add device support for XGB tuning #390
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Maybe it is better to add device in GBDT class, since all these models support GPU training. |
|
Agree with @xnuohz . Do you want to take it over (if possible)? |
|
Sure I can do that. I'll make it draft PR while I look into the other library training APIs as I'm not too familiar with those. |
|
If @xnuohz has the bandwidth, could you help with it? @adobles96 Is that okay? |
|
Sure. Should I open a new PR for this? |
|
@xnuohz thank you. Yes you can open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
devicekwarg toXGBoost._tuneandXGBoost.objectiveto enable GPU training.