-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.12 #1254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, could you re-enable fail-fast please? :)
.github/workflows/ci.yml
Outdated
@@ -7,6 +7,7 @@ jobs: | |||
linux: | |||
runs-on: ${{ matrix.PYTHON.OS || 'ubuntu-22.04' }} | |||
strategy: | |||
fail-fast: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fail-fast: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
5f45d54
to
8fe249b
Compare
.github/workflows/ci.yml
Outdated
@@ -52,6 +55,7 @@ jobs: | |||
uses: actions/setup-python@v4 | |||
with: | |||
python-version: ${{ matrix.PYTHON.VERSION }} | |||
allow-prereleases: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On our other repos we've preferred not to use allow-prereleases
, and instead to explicitly use 3.12-dev
until it's released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See @alex's comment, otherwise LGTM from my end. :)
8fe249b
to
288010c
Compare
Rebased branch of #1245
The Python 3.12 release candidate is out! 🚀
See also https://dev.to/hugovk/help-test-python-312-beta-1508/