-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch linting to ruff #1241
switch linting to ruff #1241
Conversation
basepython = python3 | ||
deps = | ||
black | ||
flake8 | ||
flake8-import-order | ||
ruff==0.0.284 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is literally our only pin, and we have no mechanism for bumping. We need to either unpin or do this in a dependabot friendly way IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a pin for mypy in the exact same way here. It definitely isn't dependabot friendly though, I agree 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its also not local dev friendly (since I know neither of us tox)
|
||
[flake8] | ||
application-import-names = OpenSSL | ||
ignore = E203,W503,W504 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably want to borrow our config from cryptography?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to merge this to get us back to green
No description provided.