docs!: add notes on thai font where accent chars collapse #460
Conversation
docs/Unicode.md
Outdated
| @@ -42,6 +42,18 @@ more information. | |||
| Then, to use a Unicode font in your script, pass `True` as the fourth parameter | |||
| of [`add_font`](fpdf/fpdf.html#fpdf.fpdf.FPDF.add_font). | |||
|
|
|||
| **Notes on Thai Fonts** | |||
There was a problem hiding this comment.
Note that the issue is not specific to Thai fonts, but applies to text in any non-lating writing system.
So maybe this could be phrased in a more general way? Using Thai as an example is of course ok.
There was a problem hiding this comment.
Sure, i just pushed the more general version. Not sure if that is ok. Let me know if there's still room for improvement. I'm not quite familiar with font and unicode thing but will do my best :)
|
Looks great to me, thank you @hackinteach for submitting this! I'm going to wait for @gmischler review on the latest version before merging this 😊 |
|
@all-contributors please add @hackinteach for documentation |
|
I've put up a pull request to add @hackinteach! 🎉 |
Codecov Report
@@ Coverage Diff @@
## master #460 +/- ##
==========================================
- Coverage 92.11% 91.96% -0.16%
==========================================
Files 22 22
Lines 6521 6398 -123
Branches 1329 1297 -32
==========================================
- Hits 6007 5884 -123
Misses 293 293
Partials 221 221
Continue to review full report at Codecov.
|
|
There's one sentence that could be phrased a bit more clearly. Other than that, a good summary of the issue and the solution! |
|
Merging this now. |
As discussed in #459 , I have added notes on Thai accent characters.