Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct spelling on index.md and readme.md #1184

Merged
merged 1 commit into from
May 25, 2024

Conversation

kuth-chi
Copy link

e.g. Fixes #0

Checklist:

  • The GitHub pipeline is OK (green),
    meaning that both pylint (static code analyzer) and black (code formatter) are happy with the changes of this PR.

  • A unit test is covering the code added / modified by this PR

  • This PR is ready to be merged

  • In case of a new feature, docstrings have been added, with also some documentation in the docs/ folder

  • A mention of the change is present in CHANGELOG.md

By submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.

@kuth-chi kuth-chi requested a review from gmischler as a code owner May 25, 2024 01:21
@Lucas-C Lucas-C merged commit 10e529d into py-pdf:master May 25, 2024
11 checks passed
@Lucas-C
Copy link
Member

Lucas-C commented May 25, 2024

Thank you @kuth-chi for fixing those spelling mistakes!

@kuth-chi
Copy link
Author

Thank you @kuth-chi for fixing those spelling mistakes!

I would like to contribute more like Khmer default font in FPDF2 is not the most using in Khmer because it's difficult to read. Can I added default font?

@kuth-chi kuth-chi deleted the localize-recorrect-spelling-kh branch May 25, 2024 06:54
@Lucas-C
Copy link
Member

Lucas-C commented May 26, 2024

Hi @kuth-chi

I would like to contribute more like Khmer default font in FPDF2 is not the most using in Khmer because it's difficult to read. Can I added default font?

In issue #700, you mentioned using the Battambang font. Is it the one difficult to read?

What do you mean by "default font" ?
Are you suggesting to add to fpdf2 documentation some recommendations about fonts to render Khmer?
Or are you suggesting something else?

@kuth-chi
Copy link
Author

Currently FPDF2 has no default Khmer font right? For Khmer characters will be display base on System or user manual adding.
I would like to add a Font example: Front https://fonts.google.com/specimen/Khmer into FPDF2 when font haven't configure for Khmer language will be display this front https://fonts.google.com/specimen/Khmer only Khmer character.

@gmischler
Copy link
Collaborator

gmischler commented May 28, 2024

fpdf2 does not have a concept of "default fonts" at all.

In all cases, the user needs to specify which font to use, either directly through set_font() or indirectly through set_fallback_fonts().
Some fonts (for latin-1 characters) are "built-in" to the PDF format, so they don't need to be loaded with add_font(), but that doesn't give them preference in any other sense.

We don't really want to recommend (let alone discourage) the use of any specific font, since this is largely a matter of opinion and taste. In "docs/Unicode.md" we list a few places where font files can be found. We could add a section there about where to find fonts for "exotic" languages that are difficult to find in the general collections. If you know one or two good places where to find khmer fonts, then that would certainly be helpful information for such a section. Ideally those would be directories of fonts, so we don't need to update individual links too often.

@kuth-chi
Copy link
Author

fpdf2 does not have a concept of "default fonts" at all.

In all cases, the user needs to specify which font to use, either directly through set_font() or indirectly through set_fallback_fonts(). Some fonts (for latin-1 characters) are "built-in" to the PDF format, so they don't need to be loaded with add_font(), but that doesn't give them preference in any other sense.

We don't really want to recommend (let alone discourage) the use of any specific font, since this is largely a matter of opinion and taste. In "docs/Unicode.md" we list a few places where font files can be found. We could add a section there about where to find fonts for "exotic" languages that are difficult to find in the general collections. If you know one or two good places where to find khmer fonts, then that would certainly be helpful information for such a section. Ideally those would be directories of fonts, so we don't need to update individual links too often.

I have post on issue #1187

Please check for detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants