Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: 优化自定义指令的类型提示 #1161

Merged
merged 3 commits into from
Jun 6, 2024
Merged

types: 优化自定义指令的类型提示 #1161

merged 3 commits into from
Jun 6, 2024

Conversation

warmthsea
Copy link
Contributor

image

@xiaoxian521
Copy link
Member

"vscodeCustomCodeColor.highlightValue" 配置可否支持数组格式呢 比如把所有自定义指令都配置为一个颜色

@xiaoxian521 xiaoxian521 self-requested a review June 5, 2024 03:43
@xiaoxian521 xiaoxian521 added the nice pr 非常好的pr label Jun 5, 2024
@warmthsea
Copy link
Contributor Author

"vscodeCustomCodeColor.highlightValue" 配置可否支持数组格式呢 比如把所有自定义指令都配置为一个颜色

不支持，这个插件我是专为指令写的，我并不希望其它指令变色

如果你想要更多的功能可以看看这个：
https://x.com/simon_he1995/status/1762365440201023845?s=46

@xiaoxian521
Copy link
Member

xiaoxian521 commented Jun 5, 2024 •
edited
Loading

好吧 那我觉得可以把这个pr颜色代码删除了
只需要类型提示就行🤝

@warmthsea
Copy link
Contributor Author

https://github.com/warmthsea/vscode-custom-code-color/releases/tag/v0.0.10
已经支持

image

@xiaoxian521 xiaoxian521 changed the title types: complete dirctives and v-auth custom color types: 优化自定义指令的类型提示 Jun 6, 2024
@xiaoxian521 xiaoxian521 merged commit a75cf83 into pure-admin:main Jun 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxian521 xiaoxian521 xiaoxian521 approved these changes

Assignees
No one assigned
Labels
nice pr 非常好的pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@warmthsea @xiaoxian521