Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add a button to reset the PROS conductor file #224

Merged
merged 5 commits into from
May 21, 2024

Conversation

Jackman3323
Copy link
Contributor

Requested Feature

A button that calls pros c reset and gives the user the associated warning and choice to continue.

Benefits of Feature

The current template/depot system sometimes causes the conductor file to break. This seems to be particularly common on macOS currently (#222). While we are looking into the root cause(s) of this issue, this button can operate as a stopgap for those users who have broken conductor files. Additionally, resetting the conductor is a frequent debugging step and a popular command.

automated CI run of prettier is bugged
please pass ci check
Copy link
Contributor

@AndrewLuGit AndrewLuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an entry in the package.json for pros.resetConductor, otherwise it looks good

src/commands/reset-conductor.ts Outdated Show resolved Hide resolved
src/commands/reset-conductor.ts Show resolved Hide resolved
Copy link
Contributor

@AndrewLuGit AndrewLuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jackman3323 Jackman3323 merged commit e9c433b into develop May 21, 2024
3 checks passed
@Jackman3323 Jackman3323 deleted the feature/reset-conductor branch May 21, 2024 01:56
Jackman3323 added a commit that referenced this pull request May 21, 2024
* ✨ Add a button to reset the PROS conductor file (#224)

* pros c reset button

Works

* fix prettier warning

automated CI run of prettier is bugged

* run prettier on new file

please pass ci check

* Allow conductor reset regardless of vscode context

Co-authored-by: BennyBot <[email protected]>

* Add package.json entry for resetConductor

---------

Co-authored-by: BennyBot <[email protected]>

* 🐛 Use tag versions to select CLI version on welcome screen (#225)

Co-authored-by: Andrew Lu <[email protected]>

* update package.json

---------

Co-authored-by: Jack Hughes <[email protected]>
Co-authored-by: BennyBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants