Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes opentelemetry-instrumentation-django from requirements.txt #5846

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Removes opentelemetry-instrumentation-django from requirements.txt #5846

merged 1 commit into from
Sep 27, 2024

Conversation

dkliban
Copy link
Member

@dkliban dkliban commented Sep 27, 2024

closes: #5843

bmbouter
bmbouter approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we are double reporting metrics. We need to remove this dependency.

@dkliban dkliban merged commit 0ff8cc7 into pulp:main Sep 27, 2024
12 checks passed
@dkliban dkliban deleted the remove-django-instrumentation branch September 27, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmbouter bmbouter bmbouter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenTelemetry metrics are reported in duplicate
2 participants
@dkliban @bmbouter