Fix URL encoding issue in pulp_file #5835
Merged
+80
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernhard
force-pushed
the
fix_5686
branch
2 times, most recently
from
c267552
to
66f87e3
Compare
|
I modified the change to not apply to Now all that is missing is a unit test. Although, to make it easy to write a unit test we probably need to split some of this out into a separate method. I don't think writing a unit test for the entire |
|
Added unit tests rather than changing how the pytest fixture webserver serves the files which seems messy to begin with. The test matrix is rather long but since the tests run very quickly I don't see the harm in being thorough :) |
|
+1 to putting this in a helper method. I guess without it would have been pretty messy to unit test. 😆 |
ggainey
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5686
Simiilar to https://github.com/pulp/pulp_deb/blob/b146fad9d894aeab89fe583a4fb60220a270744f/pulp_deb/app/tasks/synchronizing.py#L623 to quote the URL path.