working towards sending EADs to SVN #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandbergja
reviewed
May 15, 2023
| dir = | ||
| case repo | ||
| when 3 | ||
| FileUtils.mkdir_p("mudd/publicpolicy") unless Dir.exists?("mudd/publicpolicy") |
There was a problem hiding this comment.
One possible simplification: would it behave the same if you remove all FileUtils and Dir lines from the case statement, and then just add the following after the end of the case statement?
FileUtils.mkdir_p(dir) unless Dir.exists?(dir)
There was a problem hiding this comment.
It does! Much cleaner. Thanks @sandbergja !
Co-authored-by: Regine Heberlein <[email protected]> Co-authored-by: Jane Sandberg <[email protected]>
Co-authored-by: Jane Sandberg <[email protected]> Co-authored-by: Christina Chortaria <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
christinach
requested changes
Jun 27, 2023
There was a problem hiding this comment.
@regineheberlein @sandbergja thank you! I have a request regarding some comments in the code.
| def write_eads_to_file(dir, repo, id) | ||
| record = @client.get("/repositories/#{repo}/resource_descriptions/#{id}.xml") | ||
| ead = Nokogiri::XML(record.body) | ||
| # i shouldn't have to do this but I do |
| # i shouldn't have to do this but I do | ||
| ead.remove_namespaces! | ||
| eadid = ead.at_xpath('//eadid/text()') | ||
| # save file with eadid as file name |
| eadid = ead.at_xpath('//eadid/text()') | ||
| # save file with eadid as file name | ||
| file = File.open("#{dir}/#{eadid}.EAD.xml", "w") | ||
| # add back a default namespace |
| end | ||
|
|
||
| def write_eads_to_file(dir, repo, id) | ||
| record = @client.get("/repositories/#{repo}/resource_descriptions/#{id}.xml") |
There was a problem hiding this comment.
Can we add a general comment why the namespace is removed and then added back?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.