Skip to content

Commit

Permalink
[#834] Use pul:Address from the airtable staff report for the address…
Browse files Browse the repository at this point in the history
… field (#835)
  • Loading branch information
christinach committed Aug 19, 2024
1 parent 5a676d5 commit ceb6a61
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion app/models/air_table_staff/staff_directory_mapping.rb
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def fields
{ airtable_field: :'pul:Last Name', airtable_field_id: :fldvENk2uiLDHmYSw, our_field: :lastName },
{ airtable_field: :'pul:First Name', airtable_field_id: :fldnKprqGraSvNTJK, our_field: :firstName },
{ airtable_field: :Email, airtable_field_id: :fldbnDHHhDNlc2Lx8, our_field: :email },
{ airtable_field: :Address, airtable_field_id: :fldKZxmtofNbXW4qS, our_field: :address },
{ airtable_field: :'pul:Address', airtable_field_id: :fldOgGLwFSWgJoWpH, our_field: :address },
{ airtable_field: :'pul:Building', airtable_field_id: :fldz6yBenvTjdClXZ, our_field: :building },
{ airtable_field: :'pul:Department', airtable_field_id: :fld9NYFQePrPxbJJW, our_field: :department },
{ airtable_field: :Division, airtable_field_id: :fldxpCzkJmhEkVqZt, our_field: :division },
Expand Down
2 changes: 1 addition & 1 deletion spec/fixtures/files/air_table/records_no_offset.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"id": "recrhIUhcJw3lUlRE",
"createdTime": "2024-01-30T22:16:16.000Z",
"fields": {
"fldKZxmtofNbXW4qS": "123 Stokes",
"fldOgGLwFSWgJoWpH": "123 Stokes",
"fldCCTbVNKKBFXxrp": ["Virtual Reality"],
"fldxpCzkJmhEkVqZt": "Special and Distinctive Collections",
"fld9NYFQePrPxbJJW": "Special Collections",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"id": "recrhIUhcJw3dW022",
"createdTime": "2024-01-30T22:16:16.000Z",
"fields": {
"fldKZxmtofNbXW4qS": "123 Stokes",
"fldOgGLwFSWgJoWpH": "123 Stokes",
"fldCCTbVNKKBFXxrp": ["Virtual Reality"],
"fldxpCzkJmhEkVqZt": "Special and Distinctive Collections",
"fld9NYFQePrPxbJJW": "Special Collections",
Expand Down
2 changes: 1 addition & 1 deletion spec/fixtures/files/air_table/records_with_offset.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"id": "recrhIUhcJw3lUlRE",
"createdTime": "2025-01-30T22:16:16.000Z",
"fields": {
"fldKZxmtofNbXW4qS": "Firestone A floor",
"fldOgGLwFSWgJoWpH": "Firestone A floor",
"fldCCTbVNKKBFXxrp": ["Cinema history", "Robots"],
"fldxpCzkJmhEkVqZt": "Special Collections",
"fldz6yBenvTjdClXZ": "Firestone",
Expand Down
2 changes: 1 addition & 1 deletion spec/models/air_table_staff/record_list_spec.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# frozen_string_literal: true
require 'rails_helper'

BASE_AIRTABLE_URL = 'https://api.airtable.com/v0/appv7XA5FWS7DG9oe/tblM0iymGN5oqDUVm?fields%5B%5D=fld0MfgMlZd364YTR&fields%5B%5D=fld4JloN0LxiFaTiw&fields%5B%5D=fld9NYFQePrPxbJJW&fields%5B%5D=fldCCTbVNKKBFXxrp&fields%5B%5D=fldGzh0SHZqlFk3aU&fields%5B%5D=fldKZxmtofNbXW4qS&fields%5B%5D=fldL7tm4jVvYksIwl&fields%5B%5D=fldULoOUDSpoEpdAP&fields%5B%5D=fldXw9janMHvhBWvO&fields%5B%5D=fldavR3Hqxd7igWxB&fields%5B%5D=fldbnDHHhDNlc2Lx8&fields%5B%5D=fldbquJ6Hn2eq1V2h&fields%5B%5D=fldgarsg3FzD8xpE4&fields%5B%5D=fldnKprqGraSvNTJK&fields%5B%5D=fldqulY6ehd5aIbR1&fields%5B%5D=fldusiuPpfSql6vSk&fields%5B%5D=fldvENk2uiLDHmYSw&fields%5B%5D=fldw0mjDdB48HstnB&fields%5B%5D=fldxpCzkJmhEkVqZt&fields%5B%5D=fldypTXdkQGpYgVDC&fields%5B%5D=fldz6yBenvTjdClXZ&returnFieldsByFieldId=true'
BASE_AIRTABLE_URL = 'https://api.airtable.com/v0/appv7XA5FWS7DG9oe/tblM0iymGN5oqDUVm?fields%5B%5D=fld0MfgMlZd364YTR&fields%5B%5D=fld4JloN0LxiFaTiw&fields%5B%5D=fld9NYFQePrPxbJJW&fields%5B%5D=fldCCTbVNKKBFXxrp&fields%5B%5D=fldGzh0SHZqlFk3aU&fields%5B%5D=fldOgGLwFSWgJoWpH&fields%5B%5D=fldL7tm4jVvYksIwl&fields%5B%5D=fldULoOUDSpoEpdAP&fields%5B%5D=fldXw9janMHvhBWvO&fields%5B%5D=fldavR3Hqxd7igWxB&fields%5B%5D=fldbnDHHhDNlc2Lx8&fields%5B%5D=fldbquJ6Hn2eq1V2h&fields%5B%5D=fldgarsg3FzD8xpE4&fields%5B%5D=fldnKprqGraSvNTJK&fields%5B%5D=fldqulY6ehd5aIbR1&fields%5B%5D=fldusiuPpfSql6vSk&fields%5B%5D=fldvENk2uiLDHmYSw&fields%5B%5D=fldw0mjDdB48HstnB&fields%5B%5D=fldxpCzkJmhEkVqZt&fields%5B%5D=fldypTXdkQGpYgVDC&fields%5B%5D=fldz6yBenvTjdClXZ&returnFieldsByFieldId=true'

RSpec.describe AirTableStaff::RecordList do
context 'when the airtable response is not paginated' do
Expand Down
4 changes: 2 additions & 2 deletions spec/models/air_table_staff/staff_directory_person_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
'fldvENk2uiLDHmYSw': 'Archivist',
'fldnKprqGraSvNTJK': 'Phoenix',
'fldbnDHHhDNlc2Lx8': '[email protected]',
'fldKZxmtofNbXW4qS': '123 Lewis Library',
'fldOgGLwFSWgJoWpH': 'A-14J-5 Lewis Library',
'fldz6yBenvTjdClXZ': 'Stokes Library',
'fldxpCzkJmhEkVqZt': 'ReCAP',
'fld9NYFQePrPxbJJW': 'Cataloging and Metadata Services',
Expand All @@ -36,7 +36,7 @@
'Archivist', # lastName
'Phoenix', # firstName
'[email protected]', # email
'123 Lewis Library', # address
'A-14J-5 Lewis Library', # address
'Stokes Library', # building
'Cataloging and Metadata Services', # department
'ReCAP', # division
Expand Down
2 changes: 1 addition & 1 deletion spec/support/stub_airtable.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# frozen_string_literal: true
module AirtableStubbing
BASE_AIRTABLE_URL = "https://api.airtable.com/v0/appv7XA5FWS7DG9oe/tblM0iymGN5oqDUVm?fields%5B%5D=fld0MfgMlZd364YTR&fields%5B%5D=fld4JloN0LxiFaTiw&fields%5B%5D=fld9NYFQePrPxbJJW&fields%5B%5D=fldCCTbVNKKBFXxrp&fields%5B%5D=fldGzh0SHZqlFk3aU&fields%5B%5D=fldKZxmtofNbXW4qS&fields%5B%5D=fldL7tm4jVvYksIwl&fields%5B%5D=fldULoOUDSpoEpdAP&fields%5B%5D=fldXw9janMHvhBWvO&fields%5B%5D=fldavR3Hqxd7igWxB&fields%5B%5D=fldbnDHHhDNlc2Lx8&fields%5B%5D=fldbquJ6Hn2eq1V2h&fields%5B%5D=fldgarsg3FzD8xpE4&fields%5B%5D=fldnKprqGraSvNTJK&fields%5B%5D=fldqulY6ehd5aIbR1&fields%5B%5D=fldusiuPpfSql6vSk&fields%5B%5D=fldvENk2uiLDHmYSw&fields%5B%5D=fldw0mjDdB48HstnB&fields%5B%5D=fldxpCzkJmhEkVqZt&fields%5B%5D=fldypTXdkQGpYgVDC&fields%5B%5D=fldz6yBenvTjdClXZ&returnFieldsByFieldId=true"
BASE_AIRTABLE_URL = "https://api.airtable.com/v0/appv7XA5FWS7DG9oe/tblM0iymGN5oqDUVm?fields%5B%5D=fld0MfgMlZd364YTR&fields%5B%5D=fld4JloN0LxiFaTiw&fields%5B%5D=fld9NYFQePrPxbJJW&fields%5B%5D=fldCCTbVNKKBFXxrp&fields%5B%5D=fldGzh0SHZqlFk3aU&fields%5B%5D=fldOgGLwFSWgJoWpH&fields%5B%5D=fldL7tm4jVvYksIwl&fields%5B%5D=fldULoOUDSpoEpdAP&fields%5B%5D=fldXw9janMHvhBWvO&fields%5B%5D=fldavR3Hqxd7igWxB&fields%5B%5D=fldbnDHHhDNlc2Lx8&fields%5B%5D=fldbquJ6Hn2eq1V2h&fields%5B%5D=fldgarsg3FzD8xpE4&fields%5B%5D=fldnKprqGraSvNTJK&fields%5B%5D=fldqulY6ehd5aIbR1&fields%5B%5D=fldusiuPpfSql6vSk&fields%5B%5D=fldvENk2uiLDHmYSw&fields%5B%5D=fldw0mjDdB48HstnB&fields%5B%5D=fldxpCzkJmhEkVqZt&fields%5B%5D=fldypTXdkQGpYgVDC&fields%5B%5D=fldz6yBenvTjdClXZ&returnFieldsByFieldId=true"
def stub_airtable(offset: false, empty: false)
if offset
stub_airtable_with_offset
Expand Down

0 comments on commit ceb6a61

Please sign in to comment.