Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes the button spacing issue for numismatics #6503

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixes the button spacing issue for numismatics #6503

wants to merge 1 commit into from

Conversation

Seanwarren77
Copy link
Contributor

closes #6481

hackartisan
hackartisan requested changes Sep 16, 2024
View reviewed changes
Copy link
Member

@hackartisan hackartisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please include screenshots similar to the ones in the issue, showing how it looks after applying this fix?

@Seanwarren77
Copy link
Contributor Author

Screenshot 2024-09-17 at 10 58 07 AM

@hackartisan
Copy link
Member

hackartisan commented Sep 17, 2024 •
edited
Loading

It doesn't look quite right just yet. I think we should add a wrapper div with the class admin-controls around all the buttons, instead.

Here's how it looks in firefox on staging

e.g. https://figgy-staging.princeton.edu/concern/numismatics/coins/928dfea6-22ff-4282-8316-3f96efdb2d82/edit:
Screenshot 2024-09-17 at 3 06 04 PM

the edit issue screen has the same problem as above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackartisan hackartisan hackartisan requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numismatics Issue and Coin forms have bad button spacing
3 participants
@Seanwarren77 @hackartisan @pulbot