-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using new cosmwasm_schema #102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. CI does appear to be stuck though. @ueco-jb anyway to reset?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with one suggested change
Co-authored-by: Larry Engineer <[email protected]>
For some strange reason, no CircleCI build is started. I don't know why. I'll set a reminder to check again tomorrow. |
We are getting builds now :) |
It was because I asked Circle ci to check my fork... really sad! |
Strange because fork builds are enabled and they worked for other PRs here before. I see the build in https://app.circleci.com/pipelines/github/CosmWasm/cw-nfts now. |
Co-authored-by: Larry Engineer <[email protected]>
Before submitting this PR, I enabled CircleCI on my own fork and that blocked it from running it here. |
I try to implement what's in #81.
Remaining issues:
QueryMsg<Cw2981QueryMsg>
is used. As in cw721-base generates an empty response forExtension
, there is no response generated forCw2981QueryMsg
. I haven't found a solution for this.