Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ninja from 1.10.2 to 1.12.1 #324

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gudnimg
Copy link
Collaborator

@gudnimg gudnimg commented Jul 27, 2024

I'm proposing to update Ninja in the Prusa-Firmware repo. This PR is simply a proposal to keep the MMU project in sync as well.

The update brings better support for Windows :) This doesn't fix any reported issues on our side, but I don't see any harm in keeping up with the latest changes and improvements.

Some highlights:

  • Ninja uses UTF-8 now on Windows (previous versions used local ANSI encoding)
  • Support for path lengths over 260 characters on Windows

Additionally fixed one DeprecationWarning raised by Python 3.12.4 when running bootstrap.py.

Changelogs:

DeprecationWarning: Python 3.14 will, by default, filter extracted tar archives and reject files or modify their metadata. Use the filter argument to control this behavior.

See:
https://docs.python.org/3.12/library/tarfile.html#tarfile-extraction-filter
Copy link

All values in bytes. Δ Delta to base

ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
0 0 28370 1669 302 891

Copy link
Collaborator

@3d-gussner 3d-gussner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Ububtu 22.04

  1. Deleted .dependencies, build and build_gen folders
  2. Run ./utils/build.py
    a. All hex files have been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants