Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop python<=3.7 support #1877

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

kloczek
Copy link

@kloczek kloczek commented May 28, 2024

According to https://endoflife.date/python python 3.7 has been EOSed 27 Jun 2023.
Filter all code over pyupgrade --py3.8-plus.

According to https://endoflife.date/python python 3.7 has been
EOSed 27 Jun 2023.
Filter all code over `pyupgrade --py3.8-plus`.

Signed-off-by: Tomasz Kłoczko <[email protected]>
Signed-off-by: Tomasz Kłoczko <[email protected]>
@@ -169,7 +169,7 @@ def __init__(

#: Escape sequences to be injected.
self.zero_width_escapes: defaultdict[int, defaultdict[int, str]] = defaultdict(
lambda: defaultdict(lambda: "")
lambda: defaultdict(str)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not yet going to drop Python 3.7 yet. It's still too much in use today: https://pypistats.org/packages/prompt-toolkit
However, I'll cherry-pick this line, which works fine on 3.7 too.

jonathanslenders added a commit that referenced this pull request Jun 10, 2024
jonathanslenders added a commit that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants