Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #1782

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Sep 13, 2023

The second Python 3.12 release candidate is out! 🚀

Call to action

We strongly encourage maintainers of third-party Python projects to prepare their projects for 3.12 compatibilities during this phase, and where necessary publish Python 3.12 wheels on PyPI to be ready for the final release of 3.12.0.

See also https://dev.to/hugovk/help-test-python-312-beta-1508/


Python 3.7 is EOL and no longer receiving security updates (or any updates) from the core Python team.

version released eol
3.11 2022-10-24 2027-10-24
3.10 2021-10-04 2026-10-04
3.9 2020-10-05 2025-10-05
3.8 2019-10-14 2024-10-14
3.7 2018-06-26 2023-06-27

https://devguide.python.org/versions/


Also upgraded Python syntax with https://github.com/asottile/pyupgrade --py38-plus.

@doronz88
Copy link
Contributor

doronz88 commented Nov 2, 2023

Do you know if this PR is expected to be merged? or if this python project is even still maintained?

@hugovk
Copy link
Contributor Author

hugovk commented Nov 2, 2023

I expect it will at some point, and the project had a release on July so looks maintained.

And I think you can use this project on 3.12 fine without this PR.

@jonathanslenders
Copy link
Member

Sorry, I don't want to drop Python 3.7 support yet, and 3.12 should already be supported. We might want to add 3.12 to the pipeline though.

@doronz88 : This project is definitely still maintained, but that doesn't mean there's activity every day.

@hugovk hugovk changed the title Add support for Python 3.12 and drop EOL 3.7 Add support for Python 3.12 Nov 2, 2023
@hugovk
Copy link
Contributor Author

hugovk commented Nov 2, 2023

Sure, I've removed the commits dropping 3.7.

@jonathanslenders
Copy link
Member

Hi @hugovk : Would you be able to rebase on master? I applied some changes because of Ruff, and because of that, some changes here are not relevant anymore.

@jonathanslenders jonathanslenders merged commit f1a0a74 into prompt-toolkit:master Nov 3, 2023
6 checks passed
@hugovk hugovk deleted the add-3.12 branch November 3, 2023 15:42
@jonathanslenders
Copy link
Member

Thanks!

@hugovk
Copy link
Contributor Author

hugovk commented Nov 3, 2023

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants