Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix on conflict handling #1

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Lint
on:
pull_request:
push:
branches: [ master ]
branches: [ main ]
jobs:
rubocop:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/rspec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: RSpec
on:
pull_request:
push:
branches: [ master ]
branches: [ main ]
jobs:
coverage:
services:
Expand Down
4 changes: 4 additions & 0 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,7 @@ end
appraise "sidekiq-6.1" do
gem "sidekiq", "~> 6.1.0"
end

appraise "sidekiq-6.2" do
gem "sidekiq", "~> 6.2.2"
end
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
# Changelog

## [v7.1.6](https://github.com/mhenrixon/sidekiq-unique-jobs/tree/v7.1.6) (2021-09-21)

[Full Changelog](https://github.com/mhenrixon/sidekiq-unique-jobs/compare/v7.1.5...v7.1.6)

**Closed issues:**

- until\_and\_while\_executing is not running the job at all in sidekiq-unique-jobs 7.1.4 [\#626](https://github.com/mhenrixon/sidekiq-unique-jobs/issues/626)

**Merged pull requests:**

- Necessary upgrades for Sidekiq v6.2.2 [\#639](https://github.com/mhenrixon/sidekiq-unique-jobs/pull/639) ([mhenrixon](https://github.com/mhenrixon))
- Tese to these in README.md [\#633](https://github.com/mhenrixon/sidekiq-unique-jobs/pull/633) ([carrickr](https://github.com/carrickr))

## [v7.1.5](https://github.com/mhenrixon/sidekiq-unique-jobs/tree/v7.1.5) (2021-07-28)

[Full Changelog](https://github.com/mhenrixon/sidekiq-unique-jobs/compare/v7.1.4...v7.1.5)
Expand Down
26 changes: 10 additions & 16 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,39 +13,33 @@ gem "gem-release"
gem "github-markup"
gem "rack-test"
gem "rake", "13.0.3"
gem "reek", ">= 5.3"
gem "rspec"
gem "rspec-benchmark"
gem "rspec-html-matchers"
gem "rspec-its"
gem "rubocop-mhenrixon"
gem "simplecov-sublime", ">= 0.21.2", require: false
gem "sinatra"
gem "timecop"
gem "yard"

platforms :mri do
gem "concurrent-ruby-ext"
gem "fasterer"
gem "github_changelog_generator"
gem "guard"
gem "guard-bundler"
gem "guard-reek"
gem "guard-rspec"
gem "guard-rubocop"
gem "hiredis"
gem "redcarpet", "~> 3.4"
gem "reek", ">= 5.3"
gem "rspec-benchmark"
gem "rubocop-mhenrixon"
gem "ruby-prof", ">= 0.17.0", require: false
gem "simplecov-sublime", ">= 0.21.2", require: false
gem "stackprof", ">= 0.2.9", require: false
gem "test-prof"
gem "travis"
end

if respond_to?(:install_if)
install_if -> { RUBY_PLATFORM.include?("darwin") } do
gem "fasterer"
gem "fuubar"
gem "github_changelog_generator"
gem "pry"
gem "redcarpet", "~> 3.4"
gem "rspec-nc"
gem "ruby-prof", ">= 0.17.0", require: false
gem "stackprof", ">= 0.2.9", require: false
gem "test-prof"
end
end

Expand Down
61 changes: 0 additions & 61 deletions Guardfile

This file was deleted.

3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,11 @@ This gem adds unique constraints to sidekiq jobs. The uniqueness is achieved by

By default, only one lock for a given hash can be acquired. What happens when a lock can't be acquired is governed by a chosen [Conflict Strategy](#conflict-strategy) strategy. Unless a conflict strategy is chosen

This is the documentation for the master branch. You can find the documentation for each release by navigating to its tag.
This is the documentation for the `main` branch. You can find the documentation for each release by navigating to its tag.

Here are links to some of the old versions

- [v7.0.12](https://github.com/mhenrixon/sidekiq-unique-jobs/tree/v7.0.12)
- [v6.0.25](https://github.com/mhenrixon/sidekiq-unique-jobs/tree/v6.0.25)
- [v5.0.10](https://github.com/mhenrixon/sidekiq-unique-jobs/tree/v5.0.10)
- [v4.0.18](https://github.com/mhenrixon/sidekiq-unique-jobs/tree/v4.0.18)
Expand Down
29 changes: 0 additions & 29 deletions bin/guard

This file was deleted.

20 changes: 4 additions & 16 deletions gemfiles/sidekiq_5.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,33 +8,21 @@ gem "gem-release"
gem "github-markup"
gem "rack-test"
gem "rake", "13.0.3"
gem "reek", ">= 5.3"
gem "rspec"
gem "rspec-benchmark"
gem "rspec-html-matchers"
gem "rspec-its"
gem "rubocop-mhenrixon"
gem "simplecov-sublime", ">= 0.21.2", require: false
gem "sinatra"
gem "timecop"
gem "yard"
gem "sidekiq", "~> 5.0.0"

platforms :mri do
gem "concurrent-ruby-ext"
gem "fasterer"
gem "github_changelog_generator"
gem "guard"
gem "guard-bundler"
gem "guard-reek"
gem "guard-rspec"
gem "guard-rubocop"
gem "hiredis"
gem "redcarpet", "~> 3.4"
gem "reek", ">= 5.3"
gem "rspec-benchmark"
gem "rubocop-mhenrixon"
gem "ruby-prof", ">= 0.17.0", require: false
gem "simplecov-sublime", ">= 0.21.2", require: false
gem "stackprof", ">= 0.2.9", require: false
gem "test-prof"
gem "travis"
end

gemspec path: "../"
20 changes: 4 additions & 16 deletions gemfiles/sidekiq_5.1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,33 +8,21 @@ gem "gem-release"
gem "github-markup"
gem "rack-test"
gem "rake", "13.0.3"
gem "reek", ">= 5.3"
gem "rspec"
gem "rspec-benchmark"
gem "rspec-html-matchers"
gem "rspec-its"
gem "rubocop-mhenrixon"
gem "simplecov-sublime", ">= 0.21.2", require: false
gem "sinatra"
gem "timecop"
gem "yard"
gem "sidekiq", "~> 5.1.0"

platforms :mri do
gem "concurrent-ruby-ext"
gem "fasterer"
gem "github_changelog_generator"
gem "guard"
gem "guard-bundler"
gem "guard-reek"
gem "guard-rspec"
gem "guard-rubocop"
gem "hiredis"
gem "redcarpet", "~> 3.4"
gem "reek", ">= 5.3"
gem "rspec-benchmark"
gem "rubocop-mhenrixon"
gem "ruby-prof", ">= 0.17.0", require: false
gem "simplecov-sublime", ">= 0.21.2", require: false
gem "stackprof", ">= 0.2.9", require: false
gem "test-prof"
gem "travis"
end

gemspec path: "../"
20 changes: 4 additions & 16 deletions gemfiles/sidekiq_5.2.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,33 +8,21 @@ gem "gem-release"
gem "github-markup"
gem "rack-test"
gem "rake", "13.0.3"
gem "reek", ">= 5.3"
gem "rspec"
gem "rspec-benchmark"
gem "rspec-html-matchers"
gem "rspec-its"
gem "rubocop-mhenrixon"
gem "simplecov-sublime", ">= 0.21.2", require: false
gem "sinatra"
gem "timecop"
gem "yard"
gem "sidekiq", "~> 5.2.0"

platforms :mri do
gem "concurrent-ruby-ext"
gem "fasterer"
gem "github_changelog_generator"
gem "guard"
gem "guard-bundler"
gem "guard-reek"
gem "guard-rspec"
gem "guard-rubocop"
gem "hiredis"
gem "redcarpet", "~> 3.4"
gem "reek", ">= 5.3"
gem "rspec-benchmark"
gem "rubocop-mhenrixon"
gem "ruby-prof", ">= 0.17.0", require: false
gem "simplecov-sublime", ">= 0.21.2", require: false
gem "stackprof", ">= 0.2.9", require: false
gem "test-prof"
gem "travis"
end

gemspec path: "../"
20 changes: 4 additions & 16 deletions gemfiles/sidekiq_6.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,33 +8,21 @@ gem "gem-release"
gem "github-markup"
gem "rack-test"
gem "rake", "13.0.3"
gem "reek", ">= 5.3"
gem "rspec"
gem "rspec-benchmark"
gem "rspec-html-matchers"
gem "rspec-its"
gem "rubocop-mhenrixon"
gem "simplecov-sublime", ">= 0.21.2", require: false
gem "sinatra"
gem "timecop"
gem "yard"
gem "sidekiq", "~> 6.0.0"

platforms :mri do
gem "concurrent-ruby-ext"
gem "fasterer"
gem "github_changelog_generator"
gem "guard"
gem "guard-bundler"
gem "guard-reek"
gem "guard-rspec"
gem "guard-rubocop"
gem "hiredis"
gem "redcarpet", "~> 3.4"
gem "reek", ">= 5.3"
gem "rspec-benchmark"
gem "rubocop-mhenrixon"
gem "ruby-prof", ">= 0.17.0", require: false
gem "simplecov-sublime", ">= 0.21.2", require: false
gem "stackprof", ">= 0.2.9", require: false
gem "test-prof"
gem "travis"
end

gemspec path: "../"
20 changes: 4 additions & 16 deletions gemfiles/sidekiq_6.1.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,33 +8,21 @@ gem "gem-release"
gem "github-markup"
gem "rack-test"
gem "rake", "13.0.3"
gem "reek", ">= 5.3"
gem "rspec"
gem "rspec-benchmark"
gem "rspec-html-matchers"
gem "rspec-its"
gem "rubocop-mhenrixon"
gem "simplecov-sublime", ">= 0.21.2", require: false
gem "sinatra"
gem "timecop"
gem "yard"
gem "sidekiq", "~> 6.1.0"

platforms :mri do
gem "concurrent-ruby-ext"
gem "fasterer"
gem "github_changelog_generator"
gem "guard"
gem "guard-bundler"
gem "guard-reek"
gem "guard-rspec"
gem "guard-rubocop"
gem "hiredis"
gem "redcarpet", "~> 3.4"
gem "reek", ">= 5.3"
gem "rspec-benchmark"
gem "rubocop-mhenrixon"
gem "ruby-prof", ">= 0.17.0", require: false
gem "simplecov-sublime", ">= 0.21.2", require: false
gem "stackprof", ">= 0.2.9", require: false
gem "test-prof"
gem "travis"
end

gemspec path: "../"
Loading