Update to 0.14.0-rc #289
Merged
Update to 0.14.0-rc #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a few spaces and an intermediate veriable to make the code look a little bit nicer.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #289 +/- ##
==========================================
+ Coverage 90.81% 91.05% +0.24%
==========================================
Files 38 36 -2
Lines 2341 2203 -138
==========================================
- Hits 2126 2006 -120
+ Misses 215 197 -18 ☔ View full report in Codecov by Sentry. |
- Swap `receive` system between ServerEventsPlugin and `ClientEventsPlugin` to properly separate what what runs on client or server. - Move `ServerEventsPlugin::reset` logic inside `ClientEventsPlugin::reset` because this logic runs on client. - Move `server::events::event_data` module to `core::event_registry::server_event`. - Move `client::events::event_data` module to `core::event_registry::client_event`. No functional changes, except `ServerEventsPlugin` and `ClientEventsPlugin` can be disabled on client-only and server-only apps respectively. Closes #276.
I took inspiration from Bevy.
The necessary method was provided in 0.14.
Without it it will be quite hard to read the changelog (users will have to check the changes from RC) or I will need to copy all changes from RC for the upcoming 0.27.0. I also removed it from the compatibility table as suggested by @UkoeHB. I also don't think that they will be useful... Keeping them will make the table harder to read. Another option would be to keep them, but put under a spoiler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.