Update to 0.14.0 rc.2 #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shatur
force-pushed
the
0.14.0-rc.2
branch
4 times, most recently
from
ab3d937
to
3c433a2
Compare
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #282 +/- ##
==========================================
- Coverage 90.94% 90.44% -0.50%
==========================================
Files 38 36 -2
Lines 2329 2197 -132
==========================================
- Hits 2118 1987 -131
+ Misses 211 210 -1 ☔ View full report in Codecov by Sentry. |
Shatur
commented
Jun 7, 2024
| @@ -26,8 +26,7 @@ pub struct ParentSyncPlugin; | |||
| /// then you need to run it before [`ServerSet::StoreHierarchy`]. | |||
| impl Plugin for ParentSyncPlugin { | |||
| fn build(&self, app: &mut App) { | |||
| app.register_type::<Option<Entity>>() | |||
There was a problem hiding this comment.
Not needed since Bevy recursively register types.
Just a few spaces and an intermediate veriable to make the code look a little bit nicer.
UkoeHB
approved these changes
Jun 7, 2024
Comment on lines
18
to
21
| { name = "bitflags", version = "2.0" }, | ||
| { name = "cfg_aliases", version = "0.1" }, | ||
| { name = "event-listener", version = "<5.0" }, | ||
| { name = "event-listener-strategy", version = "0.5" }, |
There was a problem hiding this comment.
How do you figure out what to put in the deny.toml?
There was a problem hiding this comment.
I just run cargo deny.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't update
bevy_replicon_renet, but maybe we can do a release without it to let other developers update their messaging plugins?